feat: try quic instead tcp by abergasov · Pull Request #32 · getoptimum/optimum-gateway

abergasov · 2026-07-30T08:41:12Z

Summary by CodeRabbit

Bug Fixes
- Improved peer connectivity by switching node communication to QUIC and advertising QUIC-compatible addresses.
- Updated address prediction to use QUIC-advertised address information for more reliable peer discovery.
Tests
- Added a smoke test to verify the node starts successfully with QUIC enabled.
Documentation / Chores
- Refreshed third-party license attribution entries with updated referenced versions.

coderabbitai · 2026-07-30T08:43:28Z

📝 Walkthrough

Walkthrough

The libp2p host now registers QUIC instead of TCP, uses QUIC-over-UDP listen addresses, and builds QUIC-specific advertised addresses. Peer address prediction and startup smoke-test coverage also use the QUIC configuration. Third-party attribution links reference updated dependency versions.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant NewNode
  participant AddrsFactory
  participant QUICTransport
  NewNode->>AddrsFactory: Build QUIC advertised addresses
  NewNode->>QUICTransport: Register QUIC transport
  NewNode->>NewNode: Start node

Possibly related PRs

getoptimum/mump2p-protocol#223: Updates libp2p advertised address construction for QUIC transport selection.
getoptimum/optimum-common#177: Adds the QUIC advertised-address helper used by peer address prediction.
getoptimum/optimum-gateway#33: Contains matching QUIC host configuration and startup smoke-test changes.

Suggested reviewers: alexanderbez, cryptofewka, nicolaoun

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	Title does not follow the required (<domain/pkg>): format and omits the domain/pkg segment.	Rename it to match the required format, e.g. feat(mum_p2p): switch node transport to QUIC, under 72 chars and without trailing punctuation.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pkg/service/mum_p2p/service.go`:
- Line 99: Update the libp2p host configuration around quic.NewTransport to bind
UDP/QUIC listen addresses using /udp/<port>/quic-v1 instead of only TCP
addresses, or ensure TCP is also advertised consistently. Add a focused test
verifying the host’s advertised addresses match the configured bound transport,
covering the QUIC endpoint scheme and transport.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: getoptimum/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4333b1a9-ac00-4e4a-9a64-7db5286e0c5a

📥 Commits

Reviewing files that changed from the base of the PR and between c9421e9 and 62e2652.

⛔ Files ignored due to path filters (2)

go.mod is excluded by none and included by none
go.sum is excluded by !**/*.sum and included by none

📒 Files selected for processing (2)

pkg/service/bootstrapper/service.go
pkg/service/mum_p2p/service.go

Copilot

Pull request overview

This PR updates the mump2p networking layer to listen/advertise QUIC v1 multiaddrs (UDP) instead of TCP, and bumps/refreshes dependency metadata (Go modules, SBOM, and third-party notices) accordingly.

Changes:

Switch mum_p2p node transport from TCP to QUIC (/udp/<port>/quic-v1) and update advertised address construction.
Update bootstrapper address prediction to match the QUIC-advertised address scheme.
Bump several dependencies and refresh SBOM / third-party notice references to match.

Reviewed changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
pkg/service/mum_p2p/service.go	Switches the mump2p libp2p host to QUIC listen addrs/transport and QUIC advertised addrs.
pkg/service/bootstrapper/service.go	Updates predicted `peer.AddrInfo` to advertise QUIC multiaddrs.
go.mod	Bumps `optimum-common` and Prometheus-related dependencies (and a few indirects).
go.sum	Adds checksums for bumped module versions.
docs/sbom.json	Refreshes SBOM entries/hashes/refs to reflect updated dependencies.
THIRD-PARTY-NOTICES.md	Updates license link versions for a subset of dependencies.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+	cachedAddrs := commonnet.MustBuildAdvertisedQUICAddresses(log, publicIPV4, publicIPV6, cfg.ListenPort)

 	libP2POpts := []libp2p.Option{
 		libp2p.ConnectionManager(cn),
 		libp2p.ListenAddrStrings(
-			fmt.Sprintf("/ip4/0.0.0.0/tcp/%d", cfg.ListenPort),
-			fmt.Sprintf("/ip6/::/tcp/%d", cfg.ListenPort),
+			fmt.Sprintf("/ip4/0.0.0.0/udp/%d/quic-v1", cfg.ListenPort),
+			fmt.Sprintf("/ip6/::/udp/%d/quic-v1", cfg.ListenPort),
 		),
 		libp2p.Ping(false), // Disable Ping Service.
-		libp2p.Transport(tcp.NewTCPTransport),
+		libp2p.Transport(quic.NewTransport),
 		libp2p.DefaultMuxers,
 		libp2p.Muxer("/mplex/6.7.0", mplex.DefaultTransport),


coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pkg/service/mum_p2p/node_test.go`:
- Line 23: Replace commontest.GetFreePortT in the test configuration passed to
NewNode with a UDP/QUIC-safe port allocator that reserves the port before node
creation. Preserve the existing test setup and ensure the selected port is safe
for both IPv4 and IPv6 UDP binding.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: getoptimum/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8e03d85d-6c3f-426f-87e8-421ac9118101

📥 Commits

Reviewing files that changed from the base of the PR and between 8a8f1ac and c191284.

⛔ Files ignored due to path filters (1)

go.sum is excluded by !**/*.sum and included by none

📒 Files selected for processing (2)

pkg/service/mum_p2p/node_test.go
pkg/service/mum_p2p/service.go

quick try

62e2652

abergasov requested review from a team and swarna1101 as code owners July 30, 2026 08:41

abergasov requested a review from alexanderbez July 30, 2026 08:41

coderabbitai Bot reviewed Jul 30, 2026

View reviewed changes

Comment thread pkg/service/mum_p2p/service.go Outdated

optimum-sbom-bot and others added 2 commits July 30, 2026 08:44

chore: refresh generated artifacts

f098352

quick try

8a8f1ac

abergasov requested a review from Copilot July 30, 2026 08:51

Copilot started reviewing on behalf of abergasov July 30, 2026 08:52 View session

Copilot AI reviewed Jul 30, 2026

View reviewed changes

coderabbitai Bot mentioned this pull request Jul 30, 2026

feat: quic cleanup #33

Merged

swarna1101 approved these changes Jul 30, 2026

View reviewed changes

feat: quic cleanup (#33)

c191284

swarna1101 approved these changes Jul 30, 2026

View reviewed changes

coderabbitai Bot requested review from CryptoFewka and nicolaoun July 30, 2026 09:14

coderabbitai Bot reviewed Jul 30, 2026

View reviewed changes

Comment thread pkg/service/mum_p2p/node_test.go

hpsing approved these changes Jul 30, 2026

View reviewed changes

abergasov merged commit adf27e3 into main Jul 30, 2026
10 checks passed

abergasov deleted the _quic_try branch July 30, 2026 09:26

This was referenced Aug 3, 2026

fix: publish mump2p mesh port as udp for quic #34

Closed

Revert "feat: quic try (#32)" #49

Merged

swarna1101 added a commit that referenced this pull request Aug 6, 2026

Revert "feat: quick try (#32)" (#49)

66e391d

hpsing changed the title ~~feat: quick try~~ feat: quic try Aug 10, 2026

hpsing changed the title ~~feat: quic try~~ feat: try quic instead tcp Aug 10, 2026

Navigation Menu

Uh oh!

feat: try quic instead tcp - #32

feat: try quic instead tcp#32
abergasov merged 4 commits into
mainfrom
_quic_try

abergasov commented Jul 30, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 30, 2026 •

edited

Loading

Walkthrough

Sequence Diagram(s)

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

abergasov commented Jul 30, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Sequence Diagram(s)

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

abergasov commented Jul 30, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 30, 2026 •

edited

Loading